Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disruption.md consolidationPolicy value cases #7110

Merged
merged 2 commits into from
Oct 2, 2024
Merged

fix: disruption.md consolidationPolicy value cases #7110

merged 2 commits into from
Oct 2, 2024

Conversation

alanwu4321
Copy link
Contributor

Fixes: disruption.md consolidationPolicy value cases

Description
whenEmpty or whenEmptyOrUnderutilized are unsupported values for spec.disruption.consolidationPolicy

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alanwu4321 alanwu4321 requested a review from a team as a code owner September 28, 2024 15:54
@netlify Netlify
Copy link

netlify bot commented Sep 28, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit ab75571
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/66fcddd870b51b0008ace809
😎 Deploy Preview https://deploy-preview-7110--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

njtran
njtran previously approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you add this to the preview and v1 folder as well?

jonathan-innis
jonathan-innis approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jonathan-innis jonathan-innis enabled auto-merge (squash) October 2, 2024 05:45
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11138502907

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 96 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.3%) to 83.326%
Files with Coverage Reduction New Missed Lines %
pkg/providers/amifamily/bootstrap/bottlerocket.go 2 91.11%
pkg/providers/amifamily/bootstrap/bootstrap.go 2 92.98%
pkg/test/environment.go 3 95.9%
pkg/providers/instancetype/instancetype.go 5 95.63%
pkg/providers/instancetype/types.go 8 97.91%
pkg/operator/operator.go 8 9.55%
pkg/providers/amifamily/bootstrap/eksbootstrap.go 24 72.27%
pkg/cloudprovider/cloudprovider.go 44 73.88%
Totals Coverage Status
Change from base Build 11077084057: 0.3%
Covered Lines: 5572
Relevant Lines: 6687
💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 3913523 into aws:main Oct 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathan-innis jonathan-innis jonathan-innis approved these changes

@njtran njtran njtran left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alanwu4321 @coveralls @njtran @jonathan-innis